DESCRIPTION
The target of this audit is the private code repository of atoshi-privacy-sdk of Atoshi. Please refer to the report for the detailed audit scope.
Our audit methodology employs automated vulnerability scans, manual verification, and business logic analysis to uncover potential security issues coupled with gas and code quality optimization recommendations.
In summary, we did not find any critical issues within the audited codebase. However, we have identified some non-critical issues that should be addressed. Additionally, we have put forth notes that should be taken into consideration. It is important to note that the scope of our audit was strictly limited to the specific code versions mentioned in the report. Any updates made subsequent to our review would require a re-evaluation.
KEY FINDINGS
In total, we find 3 potential issues in the smart contract. We also have 0 recommendations and 5 notes, as follows:
| ID | Severity | Description | Status |
|---|---|---|---|
| 1 | Medium | Lack of import path for scanned notes | Fixed |
| 2 | Medium | Lack of check on the recipient in function deposit() |
Fixed |
| 3 | Medium | Lack of relayer forwarding when submitting withdrawals | Fixed |
| 4 | - | Management of sensitive wallet data | - |
| 5 | - | Operational assumptions of relayer services | - |
| 6 | - | Fixed EIP712 payload for key deviation and recovery | - |
| 7 | - | Trust assumptions of integration layer | - |
| 8 | - | Correctness of the refactored merkle module is assumed | - |
More details are provided in the audit report.
